remove WIP oauth provider#1025
Merged
Merged
Conversation
will be added back when working
Contributor
|
LGTM. Next step, finish the implementation of the |
tbouron
approved these changes
Jan 21, 2019
Member
tbouron
left a comment
tbouron
left a comment
There was a problem hiding this comment.
LGTM. I agree, this shouldn't have made it as it is WIP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
will be added back when working
it's not needed for #1024 (except for testing) and probably confusing to have in, in its current state. those who need it for testing can access it via history.
note the tokens used in here are test-only so no harm in keeping them