There are shared utility functions no longer public#1110
Merged
duncangrant merged 2 commits intoapache:masterfrom Sep 21, 2020
Merged
There are shared utility functions no longer public#1110duncangrant merged 2 commits intoapache:masterfrom
duncangrant merged 2 commits intoapache:masterfrom
Conversation
This makes AddEffectorInitializerAbstractProto public as a recent change had made it private. Alternatively we could have pushed the utility functions to the implementation.
iuliana
approved these changes
Sep 21, 2020
Contributor
|
Can we do the same for the other new Otherwise LGTM - good catch. |
iuliana
approved these changes
Sep 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes AddEffectorInitializerAbstractProto public as a recent change
had made it private. Alternatively we could have pushed the utility
functions to the implementation.