Fix bean load in osgi #1113
Merged
Fix bean load in osgi #1113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plus some misc code tidies
ensure constraints passed including when resolving
also put message in services files that services need to be declared in blueprint.xml also
the problem is that we aren't passing the loader to the bean deserializer, so it isn't looking in the right osgi bundles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent bean type add-to-catalog routines could fail in certain OSGi loading conditions around validation resolution. Format and item type are now used in that stage.
I noticed constraints also were not being passed at that stage. This is also corrected.
Tests for these have been added.