Skip to content

Serialize environment values - implement for all entities#216

Merged
asfgit merged 1 commit intoapache:masterfrom
neykov:json-env
Jul 27, 2016
Merged

Serialize environment values - implement for all entities#216
asfgit merged 1 commit intoapache:masterfrom
neykov:json-env

Conversation

@neykov
Copy link
Member

@neykov neykov commented Jun 23, 2016

Builds on #208

@grkvlt
Copy link
Member

grkvlt commented Jul 27, 2016

@neykov this is useful, although I don't much like the fact we have to do it explicitly everywhere. can't see a way of centralising it, unless we implement some kind of post-processor with a Function<T,String> toString as an option for every ConfigKey and a sensible default?

@grkvlt
Copy link
Member

grkvlt commented Jul 27, 2016

@neykov happy to merge as-is, anyway

@neykov
Copy link
Member Author

neykov commented Jul 27, 2016

That's very specific to bash environment serialization so doing a toString for config keys in general would need information on how the value would be used. I think it becomes too complex for little gain. In future I agree we could add object specific serialization when need arises.

@grkvlt
Copy link
Member

grkvlt commented Jul 27, 2016

@neykov OK, merging

@asfgit asfgit merged commit c1a9919 into apache:master Jul 27, 2016
asfgit pushed a commit that referenced this pull request Jul 27, 2016
* github/pr/216:
  Serialize environment values - implement for all entities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants