Misc cleanup of javalang, type coercion, jsonya, and Maybe#221
Merged
asfgit merged 8 commits intoapache:masterfrom Jul 7, 2016
Merged
Conversation
You can do `orThrowingUnwrapped()` to suppress the add'l caller trace, and you can change more easily change the type of the exception it will throw.
…bsent and has a toOptional, and tests
bringing it in line with json which has always allowed lists and now allows primitives, as root objects
a few more methods which were elsewhere or not present, better methods using Maybe, and callers updated to use them
with the Brooklyn TypeCoercions referring to and extending that
mainly around findMethod
| */ | ||
| public static <T> T coerce(Object value, Class<T> targetType) { | ||
| return coerce(value, TypeToken.of(targetType)); | ||
| static TypeCoercerExtensible coercer; |
Member
There was a problem hiding this comment.
I'm a bit wary of having our singleton instance as a non-final package scoped field here, is private static final better?
Member
|
@ahgittin Nice, looks like a good refactor. Minor comment about singletons...? |
fix conflict: Class.forName change upstream now ClassLoaderUtils, replicated locally
Contributor
Author
|
good idea @grkvlt , done |
ahgittin
added a commit
to ahgittin/brooklyn-server
that referenced
this pull request
Jul 7, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
big tidy is ec4da19 moving most of our static
TypeCoercionsto a non-staticutilsimpl (but not changing how we useTypeCoercions... apart from the exception it throws)others are as described in the individual commits, nothing too exciting, and big improvements to tests and javadocs
encountered while looking at how we can improve yaml type inference