Enable persistence for tests and point it at the target folder#239
Merged
asfgit merged 1 commit intoapache:masterfrom Jul 7, 2016
Merged
Enable persistence for tests and point it at the target folder#239asfgit merged 1 commit intoapache:masterfrom
asfgit merged 1 commit intoapache:masterfrom
Conversation
neykov
force-pushed
the
osgi/test-persistence
branch
from
4d120cd to
9c8a51c
Compare
neykov
force-pushed
the
osgi/test-persistence
branch
from
9c8a51c to
3b6fb3e
Compare
| junitBundles() | ||
| junitBundles(), | ||
| editConfigurationFilePut("etc/org.apache.brooklyn.osgilauncher.cfg", "persistMode", "AUTO"), | ||
| editConfigurationFilePut("etc/org.apache.brooklyn.osgilauncher.cfg", "persistenceDir", new File("target/paxexam/persistence/" + Identifiers.makeRandomId(6) + "/").getAbsolutePath()), |
Contributor
There was a problem hiding this comment.
Looks good. I presume target will get deleted at some point (e.g. on the next clean build), especially when run on local machines? So no need for tearDown to delete the folder?
With that assumption, very happy to merge. Doing so now.
Member
Author
There was a problem hiding this comment.
That was my thinking, yes. Isn't worth making it more complex just to do the cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.