Merged
Conversation
| throw Exceptions.propagate(e); | ||
| } | ||
| return Collections.list(resources); | ||
| return new ClassLoaderUtils(loader).getResources(name); |
Contributor
There was a problem hiding this comment.
ClassLoader.getResources() should return an empty Iterable. At first blush, it looks like this might throw an exception, or perhaps return null?
Contributor
|
I like the way you've shared the code - very nice! Can you add some basic tests, similar to those in ClassLoaderUtils, for getResource and getResources? |
neykov
force-pushed
the
osgi/resource-loading
branch
from
95d4f8d to
3de0e30
Compare
neykov
changed the title
neykov
force-pushed
the
osgi/resource-loading
branch
from
3de0e30 to
f55e030
Compare
Member
Author
|
Addressed comments in a separate commit, to be squashed before merge. |
Member
Author
|
Also dispatcher is not the right term for the loaders, any better suggestions? |
Contributor
|
@neykov LGTM; waiting for jenkins to confirm it works and then will merge. |
Member
Author
|
Will squash the changes in that case. |
neykov
force-pushed
the
osgi/resource-loading
branch
from
f55e030 to
b0d3070
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.