brooklyn-server karaf: don’t depend on library#248
Merged
asfgit merged 1 commit intoapache:masterfrom Jul 12, 2016
Merged
Conversation
| <feature>brooklyn-software-base</feature> | ||
| <bundle dependency="true">mvn:com.google.guava/guava/${guava.version}</bundle> | ||
| </feature> | ||
|
|
Member
There was a problem hiding this comment.
Let's leave these features in, just don't include them in the boot bundles (only change brooklyn-software-all). This should be enough not to depend on brooklyn-library at build time.
aledsage
force-pushed
the
fix/karaf-not-dependent-on-brooklyn-library
branch
from
0574140 to
2f2dccc
Compare
Don’t depend on bundles that are in brooklyn-library when building brooklyn-server: they won’t be available yet. Long-term solution is to move all of this into brooklyn-dist, and then we can re-enable these.
aledsage
force-pushed
the
fix/karaf-not-dependent-on-brooklyn-library
branch
from
2f2dccc to
47a02df
Compare
Member
|
LGTM, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don’t depend on bundles that are in brooklyn-library when building
brooklyn-server: they won’t be available yet.
Long-term solution is to move all of this into brooklyn-dist, and
then we can re-enable these.