Return when PercentageEnricher cannot compute result#249
Merged
asfgit merged 1 commit intoapache:masterfrom Jul 12, 2016
Merged
Return when PercentageEnricher cannot compute result#249asfgit merged 1 commit intoapache:masterfrom
asfgit merged 1 commit intoapache:masterfrom
Conversation
grkvlt
force-pushed
the
percentage-enricher-return-not-npe
branch
from
cf5f6c5 to
8566791
Compare
|
|
||
| if (currentDouble < 0 || totalDouble < 0) { | ||
| LOG.debug("Can't calculate Enricher ({}) value for entity ({}) as Current ({}) or total ({}) value from producer ({}) is negative, returning", new Object[]{JavaClassNames.simpleClassName(this), entity, currentDouble, totalDouble, producer}); | ||
| if (currentDouble < 0d || totalDouble < 0d) { |
Contributor
There was a problem hiding this comment.
Not sure why we disallow negative percentages, but that was already the case. So your PR looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does not pollute
INFOlog with exception stack traces. Also replaces check for zero with aDoubleMath.fuzzyCompare()call using an epsilon of 1x10^-12 to allow for floating point inaccuracies.