Convert versions to OSGi format before passing them to the OSGi runtime.#256
Merged
asfgit merged 1 commit intoapache:masterfrom Jul 13, 2016
Merged
Convert versions to OSGi format before passing them to the OSGi runtime.#256asfgit merged 1 commit intoapache:masterfrom
asfgit merged 1 commit intoapache:masterfrom
Conversation
| return Maybe.of(new VersionedName(parts[0], v)); | ||
| } | ||
|
|
||
| public static String toOsgiVersion(String version) { |
Contributor
There was a problem hiding this comment.
Worth adding a test that demonstrates the behaviour (even though the code is copy-pasted). I'd also like to see that a version such as 0.10.0-20160713.1653 is converted to 0.10.0.20160713_1653. Note the last dot is converted to an underscore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.