Move karaf distribution to brooklyn-dist. #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 22, 2016
| <feature>jclouds-api-filesystem</feature> | ||
|
|
||
| <bundle start-level="85">mvn:org.apache.brooklyn/brooklyn-locations-jclouds/${project.version}</bundle> | ||
| <feature>brooklyn-software-winrm</feature> |
Member
There was a problem hiding this comment.
winrm is part of core. Don't see where do you include the feature back (in -library and -dist PRs)?
Contributor
Author
There was a problem hiding this comment.
I had meant to move it to brooklyn-library and then realised it didn't belong there, must have missed putting it back here. Will fix.
Member
|
LGTM (apart from the missing winrm dependency) |
geomacy
force-pushed
the
move-karaf-to-dist
branch
from
e020f7e to
a2f6cb5
Compare
Contributor
Author
|
Review comments applied, squashed and pushed. |
geomacy
changed the title
Contributor
|
I've tested this - all seems to work |
asfgit
pushed a commit
that referenced
this pull request
Jul 29, 2016
asfgit
pushed a commit
to apache/brooklyn-library
that referenced
this pull request
Jul 29, 2016
Move karaf distribution to brooklyn-dist. This PR is the second of three that together move the karaf distribution to brooklyn-dist and separate out the software from brooklyn-library into separate catalog bom and feature files. This change separates out the brooklyn-library releated features into new projects in brooklyn-library itself. Merge this after apache/brooklyn-server#271.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first of three that together move the karaf distribution to brooklyn-dist and separate out the software from brooklyn-library into separate catalog bom and feature files.