Config keys and parameters can now be marked as "pinned"#354
Closed
tbouron wants to merge 1 commit intoapache:masterfrom
Closed
Config keys and parameters can now be marked as "pinned"#354tbouron wants to merge 1 commit intoapache:masterfrom
tbouron wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
Close this in favor of #358 |
asfgit
pushed a commit
that referenced
this pull request
Sep 30, 2016
Allow REST API to return the pinned config key and their constraints for catalog apps Based on #354 This expose a new `pinned` flag and `constraints` key to the REST API. It allows the following: - A blueprint can specify a config key or parameter as pinned by using `@CatalogConfig(pinned = true)` or in yaml `pinned: true` - In case of config keys or parameters pinned in YAML, the priority is auto incremented to keep the order (code lost in [this commit](6f624c7#diff-5310fbeb1f42a3a4cf0508ea441440baL82))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new behaviour is as follow:
pinned = false@CatalogConfig(pinned = true)or in yamlpinned: trueTests have been updated. Changes in docs and JSGUI coming soon.