Skip to content

Conversation

@bostko bostko force-pushed the test-JcloudsLocation-chooseReachableAddress-unit-rebase branch from d3af55d to 08bed44 Compare October 4, 2016 12:05
- verify it chooses first Public address when
  POLL_FOR_FIRST_REACHABLE_ADDRESS, is false
@bostko bostko force-pushed the test-JcloudsLocation-chooseReachableAddress-unit-rebase branch from 08bed44 to 1adc218 Compare October 4, 2016 14:12
@aledsage
Copy link
Contributor

aledsage commented Oct 4, 2016

Looks great - love the way you have made JcloudsReachableAddressStubbedTest a true unit test by stubbing out the TemplateBuilder with JcloudsStubTemplateBuilder.

I may take a look at that separately, for how much we hardcode in JcloudsStubTemplateBuilder. And look at using that in more of our tests that don't actually require real responses from the cloud provider!

Merging now.

@asfgit asfgit merged commit 1adc218 into apache:master Oct 4, 2016
asfgit pushed a commit that referenced this pull request Oct 4, 2016
@bostko bostko deleted the test-JcloudsLocation-chooseReachableAddress-unit-rebase branch January 12, 2017 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants