One instance of customizer at each customize step #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aledsage
reviewed
Oct 6, 2016
| } | ||
|
|
||
| protected Collection<JcloudsLocationCustomizer> getCustomizers(ConfigBag setup) { | ||
| public Collection<JcloudsLocationCustomizer> getCustomizers(ConfigBag setup) { |
Contributor
There was a problem hiding this comment.
I'm slightly uncomfortable about this becoming public - but I see why you had to do it, to let it be called by CloudExplorerSupport.java.
Contributor
|
LGTM; I've submitted duncangrant#1 to add some additional changes in this PR. @duncangrant can you review that - if you merge it into your branch, then it will appear automatically in this PR. |
Contributor
|
LGTM; once jenkins has confirmed the tests pass, this is good to merge. |
Change so that getCustomizers is only called once during provisioning. This ensures that only a single instance of a customizer configured with DSL will be called. This means that state can be kept between steps.
duncangrant
force-pushed
the
fix-customizers-with-config
branch
from
3134d35 to
a5470a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change so that getCustomizers is only called once during provisioning.
This ensures that only a single instance of a customizer configured
with DSL will be called. This means that state can be kept between
steps.