Make destroy on stop configurable for apps#39
Conversation
|
failure unrelated, infra problem https://issues.apache.org/jira/browse/INFRA-11316 |
| .subscribe(startable, Attributes.SERVICE_STATE_ACTUAL, listener); | ||
|
|
||
| app.start(ImmutableList.of(loc1)); | ||
| app.config().set(StartableApplication.DESTROY_ON_STOP, false); |
There was a problem hiding this comment.
The assertion below this one looks like it would fail non-deterministically.
We have added a listener (with managementContext.getSubscriptionContext(startable).subscribe(...), so that will get notifications asynchronously. Immediately after calling app.stop(), we assert that the listener has the expected events. I'd have though we'd need to use Asserts.succeedsEventually(...) when checking if the listener has received the expected notifications.
|
hi @ahgittin, we had this issue again with this build. Might be worth getting this PR merged in? |
|
good spot @aledsage. fixing that then merging /cc @Graeme-Miller we'll nail these evil nondet fails! |
Changed centos:7 image id
4 participants
should fix https://issues.apache.org/jira/browse/BROOKLYN-203 and BasicStartableTest.testTransitionsThroughLifecycles (https://builds.apache.org/job/brooklyn-master-build/16/console) failure