BROOKLYN-377: adds testConfigOnParentUsesConfigKeyDeclaredOnParent #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aledsage
force-pushed
the
BROOKLYN-377
branch
from
1a1cf35 to
be53232
Compare
aledsage
force-pushed
the
BROOKLYN-377
branch
from
be53232 to
c8c746c
Compare
aledsage
changed the title
Contributor
Author
|
#385 is now merged; I've rebased against master. The "many times" now passes for me. Assuming jenkins passes, this will be good to merge I think. |
Member
|
Looks good and build is successful, merging. |
asfgit
pushed a commit
that referenced
this pull request
Nov 10, 2016
BROOKLYN-377: adds testConfigOnParentUsesConfigKeyDeclaredOnParent This PR contains a failing test, which demonstrates the underlying problem in https://issues.apache.org/jira/browse/BROOKLYN-377. I believe that #385 will fix this. We should rebase + retest at that point. In particular, if I change `ValueResolver` to delete `.tagIfNotNull(BrooklynTaskTags.getTargetOrContextEntityTag(Tasks.current()))` then the test passes. @neykov @drigodwin you'll both likely be interested in this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a failing test, which demonstrates the underlying problem in https://issues.apache.org/jira/browse/BROOKLYN-377.
I believe that #385 will fix this. We should rebase + retest at that point. In particular, if I change
ValueResolverto delete.tagIfNotNull(BrooklynTaskTags.getTargetOrContextEntityTag(Tasks.current()))then the test passes.@neykov @drigodwin you'll both likely be interested in this.