BROOKLYN-231 fix race where updating and deleting can cause deleted item not to be deleted #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tem not to be deleted the persists and deletions run simultaneously; now, don't write things which are deleted. also suppress the immediate delta write that was previously being done; this may impact tests if there relying on an immediate checkpoint, but that's a bad test, for in normal operation checkpointing should be started when the mgmt node starts and there should be nothing to persist. if we support turning on persistence later that should trigger a full write not a delta write.
Contributor
Author
|
failure unrelated, infra problem https://issues.apache.org/jira/browse/INFRA-11316 |
| Stopwatch stopwatch = Stopwatch.createStarted(); | ||
| List<ListenableFuture<?>> futures = Lists.newArrayList(); | ||
|
|
||
| Set<String> deletedIds = MutableSet.of(); |
Contributor
There was a problem hiding this comment.
I'm surprised we need this. I can see that if one uses ImmediateDeltaChangeListener then it would happen - but that class is deprecated and not used (we should delete it).
If using PeriodicDeltaChangeListener.persistNowInternal() (which I thought all code paths would do), then it has already gone through this to remove the objects whose ids were removed.
Contributor
Author
There was a problem hiding this comment.
looks like persistNowInternal doesn't actually do that, that's why we need it
Contributor
Author
|
the problem is real so i'm going to merge but will review more after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the persists and deletions run simultaneously; now, don't write things which are deleted.
also suppress the immediate delta write that was previously being done;
this may impact tests if there relying on an immediate checkpoint, but that's a bad test,
for in normal operation checkpointing should be started when the mgmt node starts and there should be nothing to persist.
if we support turning on persistence later that should trigger a full write not a delta write.