Fix Azure ARM VM names #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neykov
suggested changes
Jan 17, 2017
| return null; | ||
| } | ||
|
|
||
| protected String generateNewIdOfLength(ConfigBag setup, int len) { |
| "vmNameMaxLength", "Maximum length of VM name", 60); | ||
|
|
||
| public static final ConfigKey<String> VM_NAME_DISALLOWED_PATTERN = ConfigKeys.newStringConfigKey( | ||
| "vmNameAllowedChars", "The character pattern to remove from a VM name", "[^a-zA-Z0-9\\-_]"); |
Member
There was a problem hiding this comment.
Name mismatch - VM_NAME_DISALLOWED_PATTERN, vmNameAllowedChars. Also not obvious it's a regex, figured it out after looking at the default value.
Prefer to have a white-list rather than a black list. I see that's a bit tricky to do with regexes. Could iterate through the characters of the string and match each one against the regex. wdyt?
Member
Author
|
Addressed comments and again tested with Tomcat 7 on Azure ARM, AWS and OpenStack |
Member
|
Thanks @drigodwin , merging. |
asfgit
pushed a commit
that referenced
this pull request
Jan 18, 2017
Fix Azure ARM VM names Azure ARM only allows alphanumeric characters in it's naming. The default for Brooklyn is to use `-` characters to split up blocks of alphanumeric chars which breaks this. This adds an exception for `azurecompute-arm` in the same style as VM name length. Tested with Tomcat 7 on Azure ARM, AWS and OpenStack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure ARM only allows alphanumeric characters in it's naming. The default for Brooklyn is to use
-characters to split up blocks of alphanumeric chars which breaks this. This adds an exception forazurecompute-armin the same style as VM name length.Tested with Tomcat 7 on Azure ARM, AWS and OpenStack