Use boolean Options correctly in ItemLister#590
Merged
asfgit merged 3 commits intoapache:masterfrom Mar 15, 2017
Merged
Conversation
added 3 commits
March 13, 2017 10:48
Replaces list-objects' --catalog-only and --ignore-impls arguments with --all-classes and --include-impls respectively. ItemLister defined a few options as booleans whose default was true. Airline treats boolean options as having zero arity and whose existence implies truth. Also removes the default from all other boolean options to make it clearer that the value is set by Airline.
sjcorbett
force-pushed
the
fix/item-lister
branch
from
8e4fc17 to
116de91
Compare
Member
|
LGTM, merging. @tbouron are there any docs that should be updated for the community catalog? |
asfgit
pushed a commit
that referenced
this pull request
Mar 15, 2017
Use boolean Options correctly in ItemLister Replaces list-objects' `--catalog-only` and `--ignore-impls` arguments with `--all-classes` and `--include-impls` respectively. ItemLister defined a few options as booleans whose default was true. Airline treats boolean options as having zero arity and whose existence implies truth. See Airline's [MetadataLoader](https://github.com/airlift/airline/blob/0.7/src/main/java/io/airlift/airline/model/MetadataLoader.java#L156) class. I've removed the default from all other boolean options to make it clearer that the value is set by Airline. CloudExplorerLiveTest passes.
Member
|
Yes, there is one: the Good catch @neykov ! |
Member
|
Thanks @tbouron. Looks like it's good, doesn't use the options changed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces list-objects'
--catalog-onlyand--ignore-implsarguments with--all-classesand--include-implsrespectively.ItemLister defined a few options as booleans whose default was true. Airline treats boolean options as having zero arity and whose existence implies truth. See Airline's MetadataLoader class.
I've removed the default from all other boolean options to make it clearer that the value is set by Airline.
CloudExplorerLiveTest passes.