BROOKLYN-451: Adds yaml-dsl rebind tests (for historic state) #593
Conversation
aledsage
force-pushed
the
test-dsl-rebind
branch
from
0dd7132 to
c8b5e13
Compare
| // See ObjectWithDefaultStringImplConverter (and its usage) for why we want to auto-detect | ||
| // annotations (usages of this is in the camp project, so we can't just list it statically | ||
| // here unfortunately). | ||
| xstream.autodetectAnnotations(true); |
There was a problem hiding this comment.
What are the performance implications of this?!
There was a problem hiding this comment.
From http://x-stream.github.io/annotations-tutorial.html#AutoDetect
In auto-detection mode XStream will have to examine any unknown class type for annotations. This will slow down the marshalling process until all processed types have been examined once.
There was a problem hiding this comment.
Seems to be about 5-10% overhead (when testing with a simple EntityMemento that has lots of string keys and brooklyn.parameters). That's certainly acceptable, to fix the issue!
aledsage
changed the title
|
|
||
| @Override | ||
| public boolean canConvert(@SuppressWarnings("rawtypes") Class type) { | ||
| return true; |
There was a problem hiding this comment.
Worth adding a comment here as to why this is hardcoded
|
LGTM |
aledsage
force-pushed
the
test-dsl-rebind
branch
from
c8b5e13 to
a536cdc
Compare
|
Thanks @neykov @m4rkmckenna. I've added the comment you suggested. Merging now. |
aledsage
changed the title
4 participants
Tests + fixes https://issues.apache.org/jira/browse/BROOKLYN-451