Skip to content

Fix memory leak in BrooklynPersistenceUtils#650

Merged
asfgit merged 1 commit intoapache:masterfrom
aledsage:fix-memory-leak
Apr 25, 2017
Merged

Fix memory leak in BrooklynPersistenceUtils#650
asfgit merged 1 commit intoapache:masterfrom
aledsage:fix-memory-leak

Conversation

@aledsage
Copy link
Contributor

@aledsage aledsage commented Apr 25, 2017

No description provided.

@geomacy
Copy link
Contributor

geomacy commented Apr 25, 2017 •
edited
Loading

LGTM; testing CatalogYamlRebindTest before this and grepping for
LocalManagementContextForTests in the output of jmap -histo:live
gives an increasing count (2nd column below) of contexts over time,
which doesn't seem right:

460:             1            160  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
452:             2            320  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
398:             3            480  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
356:             5            800  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
354:             7           1120  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
335:             9           1440  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
337:            11           1760  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
332:            13           2080  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
323:            16           2560  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
313:            18           2880  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
312:            20           3200  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
283:            23           3680  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
281:            25           4000  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
313:            28           4480  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
269:            30           4800  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
278:            32           5120  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
256:            36           5760  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
262:            37           5920  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
265:            39           6240  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
264:            41           6560  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
262:            44           7040  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
261:            46           7360  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
261:            48           7680  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
254:            50           8000  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
258:            52           8320  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
264:            56           8960  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
239:            58           9280  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
239:            59           9440  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
241:            62           9920  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
235:            64          10240  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
240:            63          10080  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
238:            64          10240  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests

with this PR things look better behaved

414:             2            320  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
368:             4            640  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
374:             4            640  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
374:             4            640  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
369:             5            800  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
396:             4            640  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
395:             4            640  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
388:             4            640  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
438:             4            640  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
365:             6            960  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
369:             6            960  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
396:             4            640  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
372:             5            800  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
454:             4            640  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
428:             4            640  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
387:             5            800  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
387:             5            800  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
405:             5            800  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
403:             5            800  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
400:             5            800  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
416:             4            640  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
443:             4            640  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
443:             4            640  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
390:             5            800  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
389:             6            960  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
409:             4            640  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
444:             4            640  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
392:             6            960  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
439:             4            640  org.apache.brooklyn.core.test.entity.LocalManagementContextForTests

@geomacy
Copy link
Contributor

geomacy commented Apr 25, 2017

LGTM merging

@asfgit asfgit merged commit 6dfb879 into apache:master Apr 25, 2017
asfgit pushed a commit that referenced this pull request Apr 25, 2017
@geomacy
Closes #650
022fb2f 
Fix memory leak in BrooklynPersistenceUtils
@aledsage aledsage deleted the fix-memory-leak branch April 25, 2017 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aledsage @geomacy @asfgit