[OSGi] Make EmbeddedFelixFramework pluggable#66
Merged
asfgit merged 2 commits intoapache:masterfrom Mar 30, 2016
Merged
Conversation
fb1b5a7 to
e34ed44
Compare
Member
Author
|
With this change next error when deploying MachineEntity is: |
Needs different implementations depending on whether running in Karaf or classical. Can't have EmbeddedFelixFramework loaded in Karaf because felix bundle doesn't export org.apache.framework packages, just generic OSGi ones.
e34ed44 to
f8db60f
Compare
Member
Author
|
After last commit (adding a dependency) I was able to deploy a The application started successfully (YAY!). The UI was behaving weirdly though, sensors & tasks were not getting populated. |
Contributor
|
👍 I like it - like the move to having the common interface, and then loading the appropriate implementation based on which mode you are running in. LGTM. |
geomacy
added a commit
to geomacy/brooklyn-server
that referenced
this pull request
Mar 22, 2016
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs different implementations depending on whether running in Karaf or classical. Can't have EmbeddedFelixFramework loaded in Karaf because felix bundle doesn't export org.apache.framework packages, just generic OSGi ones.
Needs to be rebased on master after merging #65 for a successful build.