Fix for BROOKLYN-510: failure with inboundPorts specified #713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aledsage
reviewed
May 31, 2017
| Iterable<Integer> inboundPorts = (Iterable<Integer>) setup.get(INBOUND_PORTS); | ||
| Iterable<Integer> inboundPorts = Ints.asList(template.getOptions().getInboundPorts()); | ||
|
|
||
| if (inboundPorts == null || Iterables.isEmpty(inboundPorts)) { |
Contributor
There was a problem hiding this comment.
Very minor: we could now get rid of the null check, given Ints.asList() (and template.getOptions().getInboundPorts()) will never return null.
Also, we don't need to convert it to an Iterable<Integer>. We could leave it as a int[], and change the line below to inboundPorts.length == 0. No strong feelings.
But will merge as-is.
Contributor
|
LGTM - merging now. |
Contributor
|
To what it will transform for the blueprint in BROOKLYN-510? mean |
Member
Author
|
@bostko, it should open |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on GCE / Centos 7