Skip to content

Add DigitalOcean2 and ProfitBricks features to Karaf build#760

Merged
asfgit merged 1 commit intoapache:masterfrom
sjcorbett:features
Jul 12, 2017
Merged

Add DigitalOcean2 and ProfitBricks features to Karaf build#760
asfgit merged 1 commit intoapache:masterfrom
sjcorbett:features

Conversation

@sjcorbett
Copy link
Copy Markdown
Contributor

No description provided.

@andreaturli
Copy link
Copy Markdown
Contributor

thanks @sjcorbett -- would it be useful to add a comment in the feature.xml to remember to use jclouds-all-compute from https://github.com/jclouds/jclouds-karaf/blob/master/feature/src/main/feature/feature.xml and jclouds-labs-all-compute from https://github.com/jclouds/jclouds-karaf/blob/master/feature-labs/src/main/feature/feature.xml when we bump to jclouds 2.1.x ?

@drigodwin
Copy link
Copy Markdown
Member

I think that is a good point but probably outside the scope of this PR @andreaturli so it shouldn't stop this being merged. This looks fine to me, so I'm going to merge now, thanks @sjcorbett.

Copy link
Copy Markdown
Member

@drigodwin drigodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit merged commit 57b1858 into apache:master Jul 12, 2017
asfgit pushed a commit that referenced this pull request Jul 12, 2017
@sjcorbett sjcorbett deleted the features branch July 12, 2017 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants