Skip to content

Don't skip tests jar generation during tests#77

Merged
asfgit merged 1 commit intoapache:masterfrom
neykov:fix/integration-tests-jar
Mar 24, 2016
Merged

Don't skip tests jar generation during tests#77
asfgit merged 1 commit intoapache:masterfrom
neykov:fix/integration-tests-jar

Conversation

@neykov
Copy link
Copy Markdown
Member

@neykov neykov commented Mar 23, 2016

When passed -PIntegration tests jars are not getting built on purpose. This causes build failures down the road where the missing tests-jar is a dependency in another module.

Initially introduced in apache/incubator-brooklyn@dbda0be?w=1 without any details on why it's needed.

@neykov
Copy link
Copy Markdown
Member Author

neykov commented Mar 23, 2016

Interesting, but unrelated failure:

Tests run: 1663, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 270.277 sec <<< FAILURE! - in TestSuite
testConcurrentCallToManageForbidden(org.apache.brooklyn.core.entity.proxying.ApplicationBuilderOverridingTest)  Time elapsed: 20.044 sec  <<< FAILURE!
java.lang.AssertionError: expected [true] but found [false]
    at org.testng.Assert.fail(Assert.java:94)
    at org.testng.Assert.failNotEquals(Assert.java:494)
    at org.testng.Assert.assertTrue(Assert.java:42)
    at org.testng.Assert.assertTrue(Assert.java:52)
    at org.apache.brooklyn.core.entity.proxying.ApplicationBuilderOverridingTest$11.doBuild(ApplicationBuilderOverridingTest.java:205)
    at org.apache.brooklyn.core.entity.factory.ApplicationBuilder.manage(ApplicationBuilder.java:219)
    at org.apache.brooklyn.core.entity.proxying.ApplicationBuilderOverridingTest.testConcurrentCallToManageForbidden(ApplicationBuilderOverridingTest.java:230)

/cc @aledsage

@neykov neykov force-pushed the fix/integration-tests-jar branch from 8f7d3e6 to d1abb9a Compare March 23, 2016 16:47
@ahgittin
Copy link
Copy Markdown
Contributor

LGTM

@asfgit asfgit merged commit d1abb9a into apache:master Mar 24, 2016
asfgit pushed a commit that referenced this pull request Mar 24, 2016
@neykov neykov deleted the fix/integration-tests-jar branch March 24, 2016 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants