Skip to content

Remove org.ow2.asm (already included in Karaf)#792

Merged
asfgit merged 1 commit intoapache:masterfrom
aledsage:fix-karaf-ow2.asm
Aug 4, 2017
Merged

Remove org.ow2.asm (already included in Karaf)#792
asfgit merged 1 commit intoapache:masterfrom
aledsage:fix-karaf-ow2.asm

Conversation

@aledsage
Copy link
Contributor

@aledsage aledsage commented Aug 4, 2017

I added this in #784, but turns out that broke karaf!

Including org.ow2.asm:5.0.4 breaks things badly:

Caused by: java.lang.ClassNotFoundException: org.objectweb.asm.commons.AdviceAdapter not found by org.apache.aries.proxy.impl [20]

org.ow2.asm.all:5.0.2 is already included in karaf; we'll just rely on that instead:

ASM all classes with debug info (49)
------------------------------------
Bnd-LastModified = 1398065775616
Created-By = 1.8.0 (Oracle Corporation)
Implementation-Title = ASM all classes
Implementation-Vendor = France Telecom R&D
Implementation-Version = 5.0.2
Manifest-Version = 1.0
Tool = Bnd-1.50.0

Bundle-DocURL = http://asm.objectweb.org
Bundle-ManifestVersion = 2
Bundle-Name = ASM all classes with debug info
Bundle-RequiredExecutionEnvironment = J2SE-1.3
Bundle-SymbolicName = org.objectweb.asm.all
Bundle-UpdateLocation = mvn:org.ow2.asm/asm-all/5.0.2
Bundle-Vendor = France Telecom R&D
Bundle-Version = 5.0.2

Export-Package = 
	org.objectweb.asm.signature;version=5.0.2,
	org.objectweb.asm.commons;uses:="org.objectweb.asm,org.objectweb.asm.tree,org.objectweb.asm.signature";version=5.0.2,
	org.objectweb.asm.util;uses:="org.objectweb.asm,org.objectweb.asm.tree.analysis,org.objectweb.asm.tree,org.objectweb.asm.signature";version=5.0.2,
	org.objectweb.asm.tree.analysis;uses:="org.objectweb.asm,org.objectweb.asm.tree";version=5.0.2,
	org.objectweb.asm;version=5.0.2,
	org.objectweb.asm.xml;uses:="org.xml.sax,org.objectweb.asm,org.xml.sax.helpers,org.xml.sax.ext,javax.xml.transform.sax,javax.xml.transform,javax.xml.transform.stream,org.objectweb.asm.util";version=5.0.2,
	org.objectweb.asm.tree;uses:=org.objectweb.asm;version=5.0.2
Import-Package = 
	javax.xml.transform;resolution:=optional,
	javax.xml.transform.sax;resolution:=optional,
	javax.xml.transform.stream;resolution:=optional,
	org.xml.sax;resolution:=optional,
	org.xml.sax.ext;resolution:=optional,
	org.xml.sax.helpers;resolution:=optional

Copy link
Member

@m4rkmckenna m4rkmckenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Tested locally

Cheers @aledsage ... merging now

@asfgit asfgit merged commit d873d8d into apache:master Aug 4, 2017
asfgit pushed a commit that referenced this pull request Aug 4, 2017
@aledsage aledsage deleted the fix-karaf-ow2.asm branch August 23, 2017 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants