Skip to content

Comments

Fix creation script#823

Merged
asfgit merged 2 commits intoapache:masterfrom
Graeme-Miller:patch-1
Sep 15, 2017
Merged

Fix creation script#823
asfgit merged 2 commits intoapache:masterfrom
Graeme-Miller:patch-1

Conversation

@Graeme-Miller
Copy link
Contributor

An issue was created by #812.

That PR removed the password needed to create the user brooklyn'@'localhost

@Graeme-Miller
Copy link
Contributor Author

I have tested this on a MySQLNode and it works

Copy link
Member

@drigodwin drigodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, thankyou @Graeme-Miller!

@asfgit asfgit merged commit 5a8e2d0 into apache:master Sep 15, 2017
asfgit pushed a commit that referenced this pull request Sep 15, 2017
@ahgittin
Copy link
Contributor

@Graeme-Miller @drigodwin odd - local seemed to work for me but sometimes mysql is weird which NIC/socket it uses for localhost, and different versions are different. good fix.

two things--

  • is the same update made to brooklyn-library ?

  • is there a reason we're not consistent what perms we give to the two users? (this PR gives usage to the users @ % but all to @ localhost -- previously was all on visitors and usage elsewhere, to both users) ... in other words should the file read

grant usage on *.* to 'brooklyn'@'%' identified by '${config["creation.script.password"]!"br00k11n"}';
grant all privileges on visitors.* to 'brooklyn'@'%';
# useful if sockets work also
grant all privileges on *.* to 'brooklyn'@'localhost' identified by '${config["creation.script.password"]!"br00k11n"}';
grant all privileges on visitors.* to 'brooklyn'@'localhost';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants