[BROOKLYN-542] add test for freemarker builtins hashes #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Retest this please |
aledsage
suggested changes
Oct 6, 2017
Contributor
aledsage
left a comment
aledsage
left a comment
There was a problem hiding this comment.
Do these tests fail (given BROOKLYN-532 says that builtin hashes will fail, and I don't see a fix)?
We can't merge this with failing tests.
Can you mark them with @Test(groups="Broken") instead, so that jenkins won't run them?
| assertEquals(resultForKeys.trim(), "name\nprice"); | ||
|
|
||
| String values = Joiner.on("\n").join( | ||
| "<#list attribute['map']?keys as k>", |
Contributor
There was a problem hiding this comment.
I think this should say ?values...
Contributor
Author
|
yes @aledsage this fails because of that jira issue. it's only the first commit to demonstrate the problem. I'll add a fix as soon as I have it. ( still trying to understand freemarker API) |
Contributor
Author
|
Close this for long inactivity - thanks @aledsage for your help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.