Fix execution context on subscriptions #875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahgittin
changed the title
ahgittin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execution contexts weren't getting set on subscriptions. Seems this has always been the case, and I guess subscribers weren't relying on having an execution context, but they should be able to, so policies don't always have to use their own (although they probably should for anything long-running, for cleaner task separation). This adds a test that shows the problem, then the solution which specially sets the execution context. (Pretty much everywhere else this isn't a problem because we submit via EC rather than ExecutionManager; but in subscriptions we can't do that given how task tags are passed in. Ideally should refactor LSM so that it takes the EC not the tags -- but this is easier and works just as well.)