Merged
Conversation
nakomis
force-pushed
the
ssh-sensor-value-on-error
branch
from
fde2f24 to
085fbe8
Compare
Adds `value.on.error` config key to SshCommandSensor to allow a value to be specified for use when an exception occurs when executing the ssh command
nakomis
force-pushed
the
ssh-sensor-value-on-error
branch
from
085fbe8 to
5a353b6
Compare
rdowner
approved these changes
Apr 16, 2018
Contributor
rdowner
left a comment
rdowner
left a comment
There was a problem hiding this comment.
Short and simple! Approved, will proceed to merge. Note review based on code inspection only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
value.on.errorconfig key to SshCommandSensor to allow a valueto be specified for use when an exception occurs when executing the
ssh command