Merged
Conversation
aledsage
force-pushed
the
fix-SshCommandSensor-rebind
branch
from
0f44903 to
d490115
Compare
Member
|
This LGTM, with a lot of new tests. However, I'm not very familiar with the rebind code so it would be good if another set of eyes could also review this PR |
duncangrant
approved these changes
Apr 27, 2018
duncangrant
approved these changes
Apr 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the two separate commits:
SshCommandSensorso that we don't use anonymous inner classes (making our persisted state easier to support long-term)