Persistence efficiency do less: don't persist policies/enrichers with entity #964
Conversation
geomacy
left a comment
geomacy
left a comment
There was a problem hiding this comment.
Looks good; just had a couple of minor thoughts
| addReferencedObjects(prevDeltaCollector); | ||
| } | ||
|
|
||
| if (LOG.isTraceEnabled()) LOG.trace("Checkpointing delta of memento with references: " |
There was a problem hiding this comment.
Let's move this LOG into the if above
| this.persistPoliciesEnabled = BrooklynFeatureEnablement.isEnabled(BrooklynFeatureEnablement.FEATURE_POLICY_PERSISTENCE_PROPERTY); | ||
| this.persistEnrichersEnabled = BrooklynFeatureEnablement.isEnabled(BrooklynFeatureEnablement.FEATURE_ENRICHER_PERSISTENCE_PROPERTY); | ||
| this.persistFeedsEnabled = BrooklynFeatureEnablement.isEnabled(BrooklynFeatureEnablement.FEATURE_FEED_PERSISTENCE_PROPERTY); | ||
| this.persistReferencedObjectsEnabled = BrooklynFeatureEnablement.isEnabled(BrooklynFeatureEnablement.FEATURE_REFERENCED_OBJECTS_PERSISTENCE_PROPERTY); |
There was a problem hiding this comment.
might be worth naming this rePersistReferencedObjectsEnabled as its behaviour is different from the flags above, isn't it - they disable persistence of feeds etc. entirely, whereas this just disables the periodic re-persistence. See comment on 542 below.
| addReferencedObjects(instance); | ||
| } | ||
|
|
||
| private void addReferencedObjects(BrooklynObject instance) { |
There was a problem hiding this comment.
Could this be called something different to distinguish it from the addReferencedObjects at 365, to highlight the different use? What do you think - addReferencedObjectsForInitialPersist or something?
|
Thanks @geomacy - good comments; all changes incorporated in an additional commit. |
4 participants
No description provided.