Update save to catalog action #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Donald Kennedy <andrew.kennedy@cloudsoftcorp.com>
Signed-off-by: Andrew Donald Kennedy <andrew.kennedy@cloudsoftcorp.com>
tbouron
requested changes
Nov 9, 2018
Member
tbouron
left a comment
tbouron
left a comment
There was a problem hiding this comment.
Tested it but it has a couple of issues:
- see my comments bellow
- with this configuration, the bundle name is never inferred, is that the expected behaviour?
- upon save, it displays an error (see screenshots)
ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.directive.js
Outdated
Show resolved
Hide resolved
ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.directive.js
Outdated
Show resolved
Hide resolved
ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.directive.js
Outdated
Show resolved
Hide resolved
ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.directive.js
Outdated
Show resolved
Hide resolved
grkvlt
force-pushed
the
update/save-to-catalog-action
branch
2 times, most recently
from
95f59d4 to
6a11469
Compare
Signed-off-by: Andrew Donald Kennedy <andrew.kennedy@cloudsoftcorp.com>
grkvlt
force-pushed
the
update/save-to-catalog-action
branch
from
6a11469 to
d96318f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets some default values from the blueprint and moves some items to an advanced section