Fix errors around locations in composer#125
Merged
tbouron merged 6 commits intoapache:masterfrom Mar 29, 2019
Merged
Conversation
Contributor
ahgittin
commented
Feb 22, 2019
ahgittin
commented
- now supports map syntax in the visual editor (previously gave errors)
- now works without complaining if no services set
- leaves a marker in place if a location is removed (so consumers can avoid applying defaults or reset defaults)
- fixes bug where images broke during d3 transitions
- rationalises style files, moving similar things together and promoting some shareable things
it's not a useful blueprint without this, but it's a valid one and with a validation error there you can't switch back from yaml and have issues setting locations
ahgittin
force-pushed
the
fix-locations
branch
from
77c45ce to
ca5d963
Compare
tbouron
requested changes
Feb 26, 2019
Member
tbouron
left a comment
tbouron
left a comment
There was a problem hiding this comment.
Great start, it's pretty good to have support for location definition in the composer!
I just have few comments (see below) and also a request to add the json-schema for the location, so the YAML editor will be able to show up error, if any :)
ui-modules/blueprint-composer/app/components/providers/blueprint-service.provider.js
Outdated
Show resolved
Hide resolved
ui-modules/blueprint-composer/app/components/providers/blueprint-service.provider.js
Show resolved
Hide resolved
ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js
Outdated
Show resolved
Hide resolved
ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.template.html
Outdated
Show resolved
Hide resolved
Contributor
Author
|
fixed the json, i think the rest can stand |
Contributor
Author
|
all addressed |
tbouron
approved these changes
Mar 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.