Skip to content

Remove the reserved keyword check for config keys#138

Merged
asfgit merged 1 commit into
apache:masterfrom
tbouron:fix/config-reserved-keyword
Sep 12, 2019
Merged

Remove the reserved keyword check for config keys#138
asfgit merged 1 commit into
apache:masterfrom
tbouron:fix/config-reserved-keyword

Conversation

@tbouron
Copy link
Copy Markdown
Member

@tbouron tbouron commented Sep 12, 2019

It makes sense to do this for metadata – we don't want to override brooklyn.enrichers or name. However, there shouldn't be restriction on keys within brooklyn.config.

For instance, this change allows the following blueprint:

services:
  - type: tomcat-server
    name: Foo
    brooklyn.config:
      cidrBlock: 10.0.0.0/24
      name: myVpc

whereas previously, name: myVpc would have been completely ignored by the composer.

…o this for metadata (we don't want to override `brooklyn.enrichers` or `name`) but not for keys within `brooklyn.config`
@ahgittin
Copy link
Copy Markdown
Contributor

LGTM

@asfgit asfgit closed this in 152226f Sep 12, 2019
@asfgit asfgit merged commit 0f5f5db into apache:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants