Conversation
surprisingly (to me) this _is_ permitted in maven; according to the docs it only restricts: > Properties are not supported in the following XPath elements: > `/project(/parent)?/(groupId/artifactId/version)`
| <brooklyn.version>1.0.0-SNAPSHOT</brooklyn.version><!-- BROOKLYN_VERSION --> | ||
| <build.version>${revision}</build.version> | ||
| <build.name>Apache Brooklyn</build.name> | ||
| <brooklyn.ui.relativePath.to.brooklyn.server.parent>../brooklyn-server/parent/</brooklyn.ui.relativePath.to.brooklyn.server.parent> |
There was a problem hiding this comment.
The name is a bit too much for my taste @ahgittin, I would use a simpler parent.relative.path.
But happy to go ahead and merge if it works
There was a problem hiding this comment.
assuming this is set higher up in a complex project hierarchy it needs to be namespaced appropriately. someone else might have a different parent.relative.path. agree it's a little bit silly long but at least it's totally unambiguous. :)
|
Seems maven doesn't actually respect a variable in relative path. I must have been taking some cached or downloaded item when i tested, as when we change the version it breaks. Also irritating, seems maven won't look in the local reactor model so we need either relative path to work or the upstream item to have been built. Revert this. |
4 participants
extends #160 offering a way for downstream projects to customize relative path if it causes issues