Update Brooklyn codebase to build the newly donated UI #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good. Minor changes as ^. Will check the others and merge them all. |
Member
Author
|
retest this please |
Member
Author
|
Tested latest changes from @ahgittin: did a full build and works as expected 🎉 |
Contributor
|
With the addition of apache/brooklyn#17 it builds and runs perfectly. All other PRs review. @tbouron taking a look at this last one, and once he's acked I will merge all of these. |
Contributor
|
All 6 PRs merged! TY everyone! (Missing minor fix in apache/brooklyn-docs#264 which will come shortly - it's docs so won't impact build) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace old UI by the new one.
This is part of the following PRs: