Skip to content

Allow UI modules to actively resolve conflicts#60

Merged
asfgit merged 4 commits intoapache:masterfrom
ahgittin:allow-module-start-order
Aug 20, 2018
Merged

Allow UI modules to actively resolve conflicts#60
asfgit merged 4 commits intoapache:masterfrom
ahgittin:allow-module-start-order

Conversation

@ahgittin
Copy link
Contributor

@ahgittin ahgittin commented Aug 8, 2018

Either by stopping other bundles listening on the same context-path or by specifying bundles superseded by a module being installed. See README.md for more info.

previously it was just a WAR, not including it registry, which makes it hard for downstream projects to change
@ahgittin ahgittin force-pushed the allow-module-start-order branch 2 times, most recently from 46ced31 to 014159f Compare August 9, 2018 01:30
otherwise it can be a little unpredictable which module is active
…ui-module`

previously there was a blank space for home as we filtered out the `<a>` but not the surrounding `<li>`;
now we filter the wrapping tag, and we also exclude for new `library` modules
(this allows ui modules to be registered for use in widgets etc but not included in the menu!)
@ahgittin ahgittin force-pushed the allow-module-start-order branch from 014159f to e6f7653 Compare August 9, 2018 01:56
Copy link
Member

@grkvlt grkvlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit merged commit 4d60672 into apache:master Aug 20, 2018
asfgit pushed a commit that referenced this pull request Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants