Skip to content

Conversation

@LudoPL
Copy link
Contributor

@LudoPL LudoPL commented Oct 9, 2018

Fix firefox multi-lines issue in configuration text-area in the blueprint composer

  • replace white-space "nowrap" by "pre" otherwise firefox doesn't display new lines
  • handle shift+enter (in addition to ctrl+enter and option+enter) to create a new line
  • avoid javascript error when the input is empty and new line is inserted

Signed-off-by: Ludovic Plantin ludovic.plantin@usharesoft.com

…lueprint composer

- replace white-space "nowrap" by "pre" otherwise firefox doesn't display new lines
- handle shift+enter (in addition to ctrl+enter and option+enter) to create a new line
- avoid javascript error when the input is empty and new line is inserted

Signed-off-by: Ludovic Plantin <ludovic.plantin@usharesoft.com>
@tbouron
Copy link
Member

tbouron commented Oct 10, 2018

Tested on both Firefox and Chrome, works like a charm! Thank you @ludop-usharesoft 👍

I'll merge this now. In the meantime, can you make sure you sign your ICLA? Thanks again!

@asfgit asfgit merged commit df6b98d into apache:master Oct 10, 2018
asfgit pushed a commit that referenced this pull request Oct 10, 2018
@LudoPL
Copy link
Contributor Author

LudoPL commented Oct 10, 2018

Thanks Thomas ;-)
It's ok for the ICLA, I have signed it (the 14th of June).

@LudoPL LudoPL deleted the firefox-multiline branch October 12, 2018 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants