Proposal: clarify codec/serialization module boundaries under src/ #3519
darion-yaphet
started this conversation in
Ideas
Replies: 1 comment
|
I think there is no need to change the directory structure. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
src/json2pbandsrc/mcpack2pbare currently peer directories ofsrc/brpc, although they are primarily payload codec/adapter libraries rather than complete RPC protocol implementations.This layout has historical and reuse-oriented rationale: both are public, reusable components, and
mcpack2pbalso backsprotoc-gen-mcpack. However, it is not obvious to new contributors why they are outsidesrc/brpc/policy.Would maintainers be open to either:
src/modules; orI understand that a physical move may be source-compatible only with forwarding headers and would also need to account for build rules and
protoc-gen-mcpack.This issue is intended to discuss direction before proposing code changes.
All reactions