Remove implementation specific function name of EventDispatcher#2462
Merged
wwbmmm merged 12 commits intoapache:masterfrom Feb 1, 2024
Conversation
wwbmmm
reviewed
Dec 20, 2023
| // will be kept and EPOLL_CTL_MOD will be used instead of EPOLL_CTL_DEL | ||
| // Returns 0 on success, -1 otherwise and errno is set | ||
| int RemoveEpollOut(SocketId socket_id, int fd, bool pollin); | ||
| int DeregisterEvent(SocketId socket_id, int fd, bool pollin); |
Contributor
|
和主干新合入的功能有冲突导致编译失败 @Divyansh200102 |
Contributor
Author
我会调查一下 @wwbmmm |
Contributor
Author
|
你能看看为什么最后一次检查失败吗 @wwbmmm |
Contributor
最新master分支已修复，可以更新试试。 |
Contributor
|
LGTM |
Contributor
Author
|
如果您觉得不错，请合并拉取请求@wwbmmm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes- #1894