Make naming service from sync to async#319
Closed
zyearn wants to merge 3 commits into
Closed
Conversation
jamesge
requested changes
May 24, 2018
| servers.clear(); | ||
| actions->ResetServers(servers); | ||
| } | ||
| if (bthread_usleep(std::max(FLAGS_consul_retry_interval_ms, 1) * butil::Time::kMillisecondsPerSecond) < 0) { |
|
|
||
| void PeriodicNamingService::Destroy() { | ||
| if (_task) { | ||
| _task->CleanUp(); |
| ASSERT_EQ(0, server.Start("localhost:8500", NULL)); | ||
|
|
||
| bthread_usleep(1000000); | ||
| bthread_usleep(5000000); |
Closed
|
This issue has been automatically marked as stale because it's inactive for a long time. It will be closed if no further activity occurs, reopen if you have further ideas. Thank you for your contributions! 由于很久没有活跃，此Issue已被自动标记为过期。之后几天仍无变化的话将会被关闭，若你有新想法则可重新打开。感谢你的贡献! |
gydong
reviewed
Aug 31, 2018
| // periodically or by event-driven, call methods of `actions' to tell | ||
| // RPC system about server changes. | ||
| // `actions' is owned and deleted by this naming service. | ||
| virtual void RunNamingService(const char* service_name, |
Contributor
There was a problem hiding this comment.
看本次的修改内容，主要是把所有RunNamingService的实现都从sync改为了async方式。怎么确保今后的其他实现也是async的呢？
Contributor
|
其中未提交的改动会拆分为更多的pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.