Skip to content

Fix DoRead() returns error errno #3248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenBright merged 1 commit into from
Mar 25, 2026
+3 −1
Merged

Fix DoRead() returns error errno #3248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/brpc/socket.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2106,12 +2106,14 @@ ssize_t Socket::DoRead(size_t size_hint) {
<< ": " << SSLError(e);
errno = ESSL;
} else {
int saved_errno = errno;
// System error with corresponding errno set.
bool is_fatal_error = (ssl_error != SSL_ERROR_ZERO_RETURN &&
ssl_error != SSL_ERROR_SYSCALL) ||
BIO_fd_non_fatal_error(errno) != 0 ||
BIO_fd_non_fatal_error(saved_errno) != 0 ||
nr < 0;
PLOG_IF(WARNING, is_fatal_error) << "Fail to read from ssl_fd=" << fd();
errno = saved_errno;
}
break;
}
Expand Down
Loading