Fix use after free issue of EventDispatcher LatencyRecorder#3267
Merged
wwbmmm merged 1 commit intoapache:masterfrom Apr 10, 2026
Merged
Fix use after free issue of EventDispatcher LatencyRecorder#3267wwbmmm merged 1 commit intoapache:masterfrom
wwbmmm merged 1 commit intoapache:masterfrom
Conversation
zchuango
pushed a commit
to zchuango/brpc
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve #3265
Problem Summary:
Use-After-Free crash on process exit: In
StopAndJoinGlobalDispatchers()(registered viaatexit), the globalbvar::LatencyRecorderpointersg_edisp_read_lantencyandg_edisp_write_lantencyare explicitly deleted. However, bvar's background sampler thread (bvar_sampler_collector) is a leaky singleton that is never joined or stopped. If the sampler thread is concurrently accessing these recorders when they are deleted, a Use-After-Free occurs.Unnecessary "latency" prefix stripping in
LatencyRecorder::expose().brpc/src/bvar/latency_recorder.cpp
Lines 198 to 205 in be01d10
What is changed and the side effects?
Changed:
Side effects:
Performance effects:
Breaking backward compatibility:
Check List: