Skip to content

Fix protobuf version (< 3.4.0) compatibility for ByteSizeLong() and SpaceUsedLong() #3292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wwbmmm merged 1 commit into from
May 11, 2026
+11 −0
Merged

Fix protobuf version (< 3.4.0) compatibility for ByteSizeLong() and SpaceUsedLong() #3292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/brpc/memcache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

#include "brpc/memcache.h"

#include <google/protobuf/io/coded_stream.h>
#include "brpc/policy/memcache_binary_header.h"
#include "brpc/proto_base.pb.h"
#include "butil/logging.h"
Expand Down
10 changes: 10 additions & 0 deletions src/brpc/nonreflectable_message.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,9 +163,19 @@ class NonreflectableMessage : public ::google::protobuf::Message {
#endif

// Size of bytes after serialization.
#if GOOGLE_PROTOBUF_VERSION < 3004000
virtual size_t ByteSizeLong() const {
return 0;
}

int ByteSize() const override {
return static_cast<int>(ByteSizeLong());
}
#else
size_t ByteSizeLong() const override {
return 0;
}
#endif

#if GOOGLE_PROTOBUF_VERSION >= 3007000 && GOOGLE_PROTOBUF_VERSION < 3010000
void SerializeWithCachedSizes(::google::protobuf::io::CodedOutputStream*) const override {}
Expand Down
Loading