Fix UAF in batch_create_stream_feedback_race unittest#3305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve
Problem Summary:
StreamingRpcTest.batch_create_stream_feedback_racecrasheswith SIGSEGV inside
Stream::Consume(ci1 ci2):Stream close is asynchronous:
StreamCloseonly marks the fake socketfailed; the handler's
on_closedis invoked later on the consumerbthread, when
Consumeis invoked withiter.is_queue_stopped().The test allocates
BatchStreamClientHandlerandBatchStreamFeedbackRaceStateon its stack and passes the handlerpointer to two streams via
StreamOptions::handler. It also keeps aSocketUniquePtr(client_extra_ptr) alive across the whole test bodyto enlarge the
SetConnectedrace window. That reference pins theextra stream's fake socket, so
BeforeRecycle->execution_queue_stop-> the finalConsume(is_queue_stopped)for theextra stream cannot run until
client_extra_ptritself destructs atscope exit — which happens after the handler/state stack objects have
already been destroyed. When
Consumefinally runs,_options.handleris dangling.Other tests in this file avoid the issue by setting a flag in
on_closedand waiting on it before returning, butBatchStreamClientHandler::on_closedwas empty.What is changed and the side effects?
Changed:
Side effects:
Performance effects:
Breaking backward compatibility:
Check List: