fix: prevent null dereference in fuzz test socket initialization#3314
Merged
Conversation
- Fix get_fuzz_socket() to only set initialized=true when both Socket::Create and Socket::Address succeed, allowing retry on failure - Add NULL socket checks in all 9 fuzz tests that use get_fuzz_socket() to prevent null pointer dereference when socket creation fails Fixes apache#3114
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Fix #3114
get_fuzz_socket()intest/fuzzing/fuzz_common.hsetsinitialized = trueunconditionally after the first attempt, even whenSocket::Create()orSocket::Address()fails. This causes all subsequent calls to returnNULL, and the fuzz harnesses pass thisNULLpointer directly to protocol parse functions (e.g.,ParseHuluMessage), which dereference it viasocket->remote_side(), triggering a SEGV.What is changed and how it works?
fuzz_common.h: Moveinitialized = trueinside the success branch so thatget_fuzz_socket()retries socket creation on failure instead of permanently returningNULL.All 9 fuzz test files: Add a
NULLcheck for the socket pointer before calling the parse function. If socket creation fails after retry, the test gracefully returns 0 instead of crashing.Check List
Side effects
None. Changes are limited to fuzz test harness code.