WIP: Remove the pip build element & source plugins#1419
WIP: Remove the pip build element & source plugins#1419BuildStream-Migration-Bot wants to merge 2 commits intomasterfrom
Conversation
The plugin & related tests are moved to bst-plugins-experimental, NEWS updated to reflect this
The plugin & related tests are moved to bst-plugins-experimental, NEWS updated to reflect this
BuildStream-Migration-Bot
requested review from
BenjaminSchubert,
cs-shadow,
gtristan and
juergbi
as code owners
|
In GitLab by [Gitlab user @tpollard] on Jan 23, 2020, 13:53 mentioned in merge request bst-plugins-experimental!78 |
|
In GitLab by [Gitlab user @tpollard] on Jan 23, 2020, 15:28 Looks like the cache key tests have a pip target , this will need addressing before un-WIP https://gitlab.com/BuildStream/buildstream/blob/master/tests/cachekey/project/target.bst |
|
In GitLab by [Gitlab user @jjardon] on Jan 24, 2020, 11:05 changed the description |
|
In GitLab by [Gitlab user @tpollard] on Jan 24, 2020, 13:33 added 5 commits
|
|
In GitLab by [Gitlab user @jjardon] on Jan 27, 2020, 11:43 changed the description |
|
In GitLab by [Gitlab user @tpollard] on Jan 29, 2020, 11:52 added 9 commits
|
|
In GitLab by [Gitlab user @tpollard] on Feb 4, 2020, 11:05 As https://gitlab.com/BuildStream/bst-plugins-experimental/merge_requests/78 is now merged this MR just requires the cachekey test to be resolved along with pointing at the required version of bst-plugins-external |
|
In GitLab by [Gitlab user @tpollard] on Feb 11, 2020, 16:06 added 47 commits |
|
In GitLab by [Gitlab user @traveltissues] on Apr 23, 2020, 08:22 this seems to be resolved: https://gitlab.com/BuildStream/buildstream/-/commit/505f77f56f98212910079fb82e77c48caae4a7a8 is there anything else missing? |
|
In GitLab by [Gitlab user @BenjaminSchubert] on Apr 23, 2020, 09:09 The cachekey test needs updating, but there is currently no way of doing it. I have a branch almost ready that would enable that. I'll prioritize it |
|
In GitLab by [Gitlab user @BenjaminSchubert] on Apr 23, 2020, 09:10 Ah sorry, didn't realize this commit removed it. I guess this then needs rebasing |
|
In GitLab by [Gitlab user @tpollard] on May 11, 2020, 20:46 I assume with https://gitlab.com/BuildStream/buildstream/-/merge_requests/1911 being merged this MR can now be closed. Feel free to. |
|
In GitLab by [Gitlab user @BenjaminSchubert] on May 11, 2020, 20:57 Woops forgot about that one. !1911 removed only the pip element, not the pip source. A bit more work is needed for the pip source, but I think that after !1915, we should be able to remove it entirely. |
|
Plugins have been moved to https://github.com/apache/buildstream-plugins now. |
3 participants
See original merge request on GitLab
In GitLab by [Gitlab user @tpollard] on Jan 23, 2020, 13:52
Description
WIP until the plugins has been merged to bst-plugins-experimental, at which point
BST_PLUGINS_EXPERIMENTAL_VERSIONin tox.ini can be bumped as well asBST_EXT_REFin gitlabci which has two references. This is part of https://gitlab.com/BuildStream/buildstream/issues/1224MR for bst-plugins-experimental: https://gitlab.com/BuildStream/bst-plugins-experimental/merge_requests/78
Changes proposed in this merge request: