element.py: Compute cache key also for rdep without buildable callback#1457
Merged
Conversation
juergbi
requested review from
BenjaminSchubert,
cs-shadow and
gtristan
as code owners
Contributor
Author
|
As the issue is essentially a race condition, writing a reliable regression test for the test suite may no be straight forward, unfortunately. I was able to reproduce the issue manually with a clean freedesktop-sdk build, though, and I've verified the fix manually the same way. |
BenjaminSchubert
approved these changes
Mar 18, 2021
Source cache status is not always available for non-build pipelines. Don't call `_fetch_needed()` if `__assemble_scheduled` is `False`.
juergbi
force-pushed
the
juerg/non-strict-cache-key
branch
from
51b6fe1 to
7b5a125
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reverse dependency may not be in the build queue yet and thus, the buildable callback may be
None. However, it's still necessary to update the cache key in non-strict mode.Fixes #1452.
Fixes: 8d9bf02 ("element.py: Stop computing cache keys when...")