Query sources of cached elements in build pipeline with source push enabled#1458
Merged
Conversation
juergbi
requested review from
BenjaminSchubert,
cs-shadow and
gtristan
as code owners
juergbi
force-pushed
the
juerg/build-with-source-push
branch
from
5af9829 to
41db457
Compare
`_pull_pending()` is now a trivial method and it doesn't make sense to guard it with `_can_query_cache()`.
It's correct to call `_load_artifact_done()` if the pull was unsuccessful because the artifact is not available on the server. However, if an error is raised (e.g. job was terminated or an internal error), we must not call `_load_artifact_done()` as no artifact object is available.
This is a clarification in preparation for an additional parameter.
This is a regression test for #1456.
juergbi
force-pushed
the
juerg/build-with-source-push
branch
from
41db457 to
95e0190
Compare
BenjaminSchubert
approved these changes
Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source cache status of all elements is required if source push is enabled, independent of whether the artifact is already available.
Fixes #1456.
Fixes: 2003805 ("Move artifact and source cache query trigger to...")